Fix fim not exiting when keys to exit are pressed (refuses to kill the process) #8

New issue

Closed

opened 2020-09-03 04:51:47 +00:00 by kemonine · 1 comment

kemonine commented

2020-09-03 04:51:47 +00:00

Owner

https://bigkevmcd.github.io/go/pgrp/context/2019/02/19/terminating-processes-in-go.html

https://stackoverflow.com/questions/11886531/terminating-a-process-started-with-os-exec-in-golang

https://bigkevmcd.github.io/go/pgrp/context/2019/02/19/terminating-processes-in-go.html https://stackoverflow.com/questions/11886531/terminating-a-process-started-with-os-exec-in-golang

kemonine added the

bug

help wanted

labels 2020-09-03 04:51:51 +00:00

kemonine commented

2020-09-03 05:05:23 +00:00

Author

Owner

This was due to the bash process executing fim and the Kill() method only killing the main process, NOT sub processes (this is documented in the go docs as a quirk)

Solution was to use progress groups (NON PORTABLE, NO WINDOWS SUPPORT) and kill the whole process group.

This was due to the bash process executing fim and the Kill() method only killing the main process, NOT sub processes (this is documented in the go docs as a quirk) Solution was to use progress groups (NON PORTABLE, NO WINDOWS SUPPORT) and kill the whole process group.

kemonine closed this issue

2020-09-03 05:05:23 +00:00